Load TransformerChain model file in ModelFileUtils - #4110
Merged
Conversation
eerhardt
reviewed
Aug 14, 2019
eerhardt
left a comment
eerhardt
left a comment
Member
There was a problem hiding this comment.
Can you add a test for this scenario?
eerhardt
reviewed
Aug 14, 2019
eerhardt
reviewed
Aug 14, 2019
eerhardt
approved these changes
Aug 15, 2019
eerhardt
left a comment
eerhardt
left a comment
Member
There was a problem hiding this comment.
Looks good. Thanks @najeeb-kazmi!
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4109
Related to microsoft/NimbusML#201
Enables loading TransformerChain models from entrypoints. This is needed so that models trained in ML.NET can be scored in NimbusML.
NimbusML models could be loaded and scored in ML.NET, but we never tested it the other way around.